retroarch: Hide "Core Downloader" to prevent nonfree cores from being installed

Bug Report Template

Please read [Feature Request] Add "Show Free Content Only" filter for details before working on this issue or asking questions.


1. Affected Package revision / version

retroarch 1.18.0


2. Steps to Reproduce

  1. sudo apt-get update -y && sudo apt-get install retroarch
  2. Open retroarch
  3. Navigate to: Main Menu → Online Updater
  4. Observe that there is no Core Downloader sub-menu in the absolute top.
  5. Navigate to: Settings → User Interface → Menu Visibility
  6. Enable: Show 'Core Downloader'
  7. Repeat step 3
  8. Observe that Core Downloader sub-menu is now in the absolute top.
  9. Open Core Downloader

3. Current Behavior

Observe that nonfree cores are listed, for example all Snes9x cores, including Nintendo - SNES / SFC (Snes9x - Current)

image


4. Expected Behavior (optional)


5. Workaround (optional)

Until [Feature Request] Add "Show Free Content Only" filter has been fixed, remove this menu item (like in the old retroarch package from trisquel 11.0.1): Settings → User Interface → Menu Visibility → Show 'Core Downloader'


6. Suggestions, Investigation and Possible Causes


7. Other Tests (optional)

While the Settings > User Interface > Menu Visibility > Show 'Core Downloader' option was previously unavailable in older versions like retroarch 1.7.3 on Trisquel 11.0.1, this has since changed. In retroarch 1.18.0 on Trisquel 12, the option is present.


Edited by David Hedlund
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information