WIP: accountsservice: enable users with low uid to be configured as non-systemusers
The patch requires adjustment to work on the aramo version.
dpkg-buildpackage
-----------------
Command: dpkg-buildpackage --sanitize-env -us -uc -b -rfakeroot -j4
dpkg-buildpackage: info: source package accountsservice
dpkg-buildpackage: info: source version 22.07.5-2ubuntu1.3+11.0trisquel1
dpkg-buildpackage: info: source distribution aramo-security
dpkg-buildpackage: info: source changed by Trisquel GNU/Linux developers <trisquel-devel@listas.trisquel.info>
dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
fakeroot debian/rules clean
dh clean --with=gir,translations
dh_clean
debian/rules build
dh build --with=gir,translations
dh_update_autotools_config
dh_autoreconf
debian/rules override_dh_auto_configure
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_configure -- \
-Ddocbook=true \
-Dgdmconffile=/etc/gdm3/custom.conf \
-Dadmin_group=sudo \
-Dsystemdsystemunitdir=/lib/systemd/system \
-Dintrospection=true \
-Dextra_admin_groups=adm,cdrom,dip,lpadmin,plugdev,sambashare,libvirtd,lxd \
-Dgtk_doc=true
cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu -Ddocbook=true -Dgdmconffile=/etc/gdm3/custom.conf -Dadmin_group=sudo -Dsystemdsystemunitdir=/lib/systemd/system -Dintrospection=true -Dextra_admin_groups=adm,cdrom,dip,lpadmin,plugdev,sambashare,libvirtd,lxd -Dgtk_doc=true
The Meson build system
Version: 0.61.2
Source dir: /<<PKGBUILDDIR>>
Build dir: /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu
Build type: native build
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: https://github.com/mesonbuild/meson/issues/9300
Project name: accountsservice
Project version: 22.07.5
C compiler for the host machine: cc (gcc 11.2.0 "cc (Ubuntu 11.2.0-19ubuntu1) 11.2.0")
C linker for the host machine: cc ld.bfd 2.38
Host machine cpu family: x86_64
Host machine cpu: x86_64
Has header "paths.h" : YES
Has header "shadow.h" : YES
Has header "utmpx.h" : YES
Checking for function "getusershell" : YES
Checking for function "setutxdb" : NO
Checking for function "fgetpwent" : YES
Header <utmpx.h> has symbol "WTMPX_FILENAME" : YES
Checking if "value of WTMPX_FILENAME" runs: YES
Message: whether optimization is enabled: false
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Run-time dependency gio-2.0 found: YES 2.72.1
Run-time dependency gio-unix-2.0 found: YES 2.72.1
Run-time dependency glib-2.0 found: YES 2.72.1
Run-time dependency polkit-gobject-1 found: YES 0.105
Run-time dependency libxcrypt found: YES 4.4.27
Run-time dependency dbus-1 found: YES 1.12.20
Run-time dependency libsystemd found: YES 249
Configuring org.freedesktop.Accounts.service using configuration
Configuring accounts-daemon.service using configuration
Program gdbus-codegen found: YES (/usr/bin/gdbus-codegen)
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Program gdbus-codegen found: YES (/usr/bin/gdbus-codegen)
Program glib-mkenums found: YES (/usr/bin/glib-mkenums)
Program glib-mkenums found: YES (/usr/bin/glib-mkenums)
Compiler for C supports link arguments -Wl,--version-script,/<<PKGBUILDDIR>>/src/libaccountsservice/symbol.map: YES
Run-time dependency gobject-introspection-1.0 found: YES 1.72.0
Dependency gobject-introspection-1.0 found: YES 1.72.0 (cached)
Program g-ir-scanner found: YES (/usr/bin/g-ir-scanner)
Dependency gobject-introspection-1.0 found: YES 1.72.0 (cached)
Program g-ir-compiler found: YES (/usr/bin/g-ir-compiler)
Program vapigen found: YES (/usr/bin/vapigen)
WARNING: Unknown keyword arguments in target accountsservice.vapi: packages
Program xsltproc found: YES (/usr/bin/xsltproc)
Configuring AccountsService.xml using configuration
Program xmlto found: YES (/usr/bin/xmlto)
Program gtkdoc-scan found: YES (/usr/bin/gtkdoc-scan)
Program gtkdoc-scangobj found: YES (/usr/bin/gtkdoc-scangobj)
Program gtkdoc-mkdb found: YES (/usr/bin/gtkdoc-mkdb)
Program gtkdoc-mkhtml found: YES (/usr/bin/gtkdoc-mkhtml)
Program gtkdoc-fixxref found: YES (/usr/bin/gtkdoc-fixxref)
Program python3 found: YES (/usr/bin/python3)
Program unittest_inspector.py found: YES (/<<PKGBUILDDIR>>/tests/unittest_inspector.py)
Configuring config.h using configuration
Message:
accountsservice was configured with the following options:
** DocBook documentation build: true
** Administrator group: sudo
** Extra administrator groups: adm,cdrom,dip,lpadmin,plugdev,sambashare,libvirtd,lxd
** GDM configuration: /etc/gdm3/custom.conf
Build targets in project: 95
NOTICE: Future-deprecated features used:
* 0.56.0: {'Dependency.get_pkgconfig_variable', 'meson.build_root'}
accountsservice 22.07.5
User defined options
buildtype : plain
libdir : lib/x86_64-linux-gnu
localstatedir : /var
prefix : /usr
sysconfdir : /etc
wrap_mode : nodownload
admin_group : sudo
docbook : true
extra_admin_groups : adm,cdrom,dip,lpadmin,plugdev,sambashare,libvirtd,lxd
gdmconffile : /etc/gdm3/custom.conf
gtk_doc : true
introspection : true
systemdsystemunitdir: /lib/systemd/system
Found ninja-1.10.1 at /usr/bin/ninja
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build
cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j4 -v
[1/102] /usr/bin/gdbus-codegen --glib-min-required 2.64 --c-generate-autocleanup all --interface-prefix org.freedesktop. --c-namespace Accounts --header --output src/accounts-generated.h /<<PKGBUILDDIR>>/data/org.freedesktop.Accounts.xml
[2/102] /usr/bin/gdbus-codegen --glib-min-required 2.64 --c-generate-autocleanup all --interface-prefix org.freedesktop. --c-namespace Accounts --body --output src/accounts-generated.c /<<PKGBUILDDIR>>/data/org.freedesktop.Accounts.xml
[3/102] /usr/bin/gdbus-codegen --glib-min-required 2.64 --c-generate-autocleanup all --interface-prefix org.freedesktop.Accounts. --c-namespace Accounts --body --output src/accounts-user-generated.c /<<PKGBUILDDIR>>/data/org.freedesktop.Accounts.User.xml
[4/102] msgfmt ../po/af.po -o po/af/LC_MESSAGES/accounts-service.mo
[5/102] msgfmt ../po/ar.po -o po/ar/LC_MESSAGES/accounts-service.mo
[6/102] /usr/bin/gdbus-codegen --glib-min-required 2.64 --c-generate-autocleanup all --interface-prefix org.freedesktop.Accounts. --c-namespace Accounts --header --output src/accounts-user-generated.h /<<PKGBUILDDIR>>/data/org.freedesktop.Accounts.User.xml
[7/102] msgfmt ../po/as.po -o po/as/LC_MESSAGES/accounts-service.mo
[8/102] /usr/bin/meson --internal exe --capture src/libaccountsservice/act-user-enum-types.h -- /usr/bin/glib-mkenums --template /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/../src/libaccountsservice/act-user-enum-types.h.template /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/../src/libaccountsservice/act-user.h /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/../src/libaccountsservice/act-user-manager.h
[9/102] /usr/bin/meson --internal msgfmthelper ../data/org.freedesktop.accounts.policy.in data/org.freedesktop.accounts.policy xml /<<PKGBUILDDIR>>/po
[10/102] cc -Isrc/accounts-daemon.p -Isrc -I../src -I. -I.. -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/polkit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DLOCALSTATEDIR="/var"' '-DDATADIR="/usr/share"' '-DSYSCONFDIR="/etc"' '-DICONDIR="/var/lib/AccountsService/icons"' '-DUSERDIR="/var/lib/AccountsService/users"' -MD -MQ src/accounts-daemon.p/daemon.c.o -MF src/accounts-daemon.p/daemon.c.o.d -o src/accounts-daemon.p/daemon.c.o -c ../src/daemon.c
FAILED: src/accounts-daemon.p/daemon.c.o
cc -Isrc/accounts-daemon.p -Isrc -I../src -I. -I.. -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/polkit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DLOCALSTATEDIR="/var"' '-DDATADIR="/usr/share"' '-DSYSCONFDIR="/etc"' '-DICONDIR="/var/lib/AccountsService/icons"' '-DUSERDIR="/var/lib/AccountsService/users"' -MD -MQ src/accounts-daemon.p/daemon.c.o -MF src/accounts-daemon.p/daemon.c.o.d -o src/accounts-daemon.p/daemon.c.o -c ../src/daemon.c
../src/daemon.c: In function ‘entry_generator_fgetpwent’:
../src/daemon.c:260:136: error: ‘*spent’ is a pointer; did you mean to use ‘->’?
260 | if (!assume_human_user && !user_classify_is_human (pwent->pw_uid, pwent->pw_name, pwent->pw_shell, spent? spent->sp_pwdp : NULL)) {
| ^~
| ->
../src/daemon.c:263:40: error: too few arguments to function ‘entry_generator_fgetpwent’
263 | return entry_generator_fgetpwent (daemon, users, state, spent);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
../src/daemon.c:177:1: note: declared here
177 | entry_generator_fgetpwent (Daemon *daemon,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
../src/daemon.c: In function ‘finish_list_cached_users’:
../src/daemon.c:1034:67: error: ‘shell’ undeclared (first use in this function)
1034 | if (!human && !user_classify_is_human (uid, name, shell, NULL)) {
| ^~~~~
../src/daemon.c:1034:67: note: each undeclared identifier is reported only once for each function it appears in
[11/102] cc -Isrc/accounts-daemon.p -Isrc -I../src -I. -I.. -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/polkit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DLOCALSTATEDIR="/var"' '-DDATADIR="/usr/share"' '-DSYSCONFDIR="/etc"' '-DICONDIR="/var/lib/AccountsService/icons"' '-DUSERDIR="/var/lib/AccountsService/users"' -MD -MQ src/accounts-daemon.p/extensions.c.o -MF src/accounts-daemon.p/extensions.c.o.d -o src/accounts-daemon.p/extensions.c.o -c ../src/extensions.c
[12/102] cc -Isrc/libaccounts-generated.a.p -Isrc -I../src -I. -I.. -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gio-unix-2.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread '-DLOCALSTATEDIR="/var"' '-DDATADIR="/usr/share"' '-DSYSCONFDIR="/etc"' '-DICONDIR="/var/lib/AccountsService/icons"' '-DUSERDIR="/var/lib/AccountsService/users"' -MD -MQ src/libaccounts-generated.a.p/meson-generated_.._accounts-generated.c.o -MF src/libaccounts-generated.a.p/meson-generated_.._accounts-generated.c.o.d -o src/libaccounts-generated.a.p/meson-generated_.._accounts-generated.c.o -c src/accounts-generated.c
[13/102] cc -Isrc/libaccounts-generated.a.p -Isrc -I../src -I. -I.. -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gio-unix-2.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread '-DLOCALSTATEDIR="/var"' '-DDATADIR="/usr/share"' '-DSYSCONFDIR="/etc"' '-DICONDIR="/var/lib/AccountsService/icons"' '-DUSERDIR="/var/lib/AccountsService/users"' -MD -MQ src/libaccounts-generated.a.p/meson-generated_.._accounts-user-generated.c.o -MF src/libaccounts-generated.a.p/meson-generated_.._accounts-user-generated.c.o.d -o src/libaccounts-generated.a.p/meson-generated_.._accounts-user-generated.c.o -c src/accounts-user-generated.c
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j4 -v returned exit code 1
make: *** [debian/rules:16: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2022-08-30T07:40:08Z
Finished
--------
+------------------------------------------------------------------------------+
| Cleanup |
+------------------------------------------------------------------------------+
Purging /<<BUILDDIR>>
Not cleaning session: cloned chroot in use
E: Build failure (dpkg-buildpackage died)
+------------------------------------------------------------------------------+
| Summary |
+------------------------------------------------------------------------------+
Build Architecture: amd64
Build Type: binary
Build-Space: 5780
Build-Time: 6
Distribution: aramo
Fail-Stage: build
Host Architecture: amd64
Install-Time: 44
Job: accountsservice_22.07.5-2ubuntu1.3+11.0trisquel1.dsc
Machine Architecture: amd64
Package: accountsservice
Package-Time: 83
Source-Version: 22.07.5-2ubuntu1.3+11.0trisquel1
Space: 5780
Status: attempted
Version: 22.07.5-2ubuntu1.3+11.0trisquel1
--------------------------------------------------------------------------------
Finished at 2022-08-30T07:40:08Z
Build needed 00:01:23, 5780k disk space
E: Build failure (dpkg-buildpackage died)